chore: adopt American English across the project#192
Merged
Conversation
Normalize British spellings to American English in javadoc, comments, docs, and internal identifiers (recognize/optimize/finalize/serialize/ materialize/behavior/color — never -ise/-isation/-our). Matches the JDK (Object.finalize, Serializable). - Add the rule to CLAUDE.md under code style. - Verb stems flipped only on the -is(e|ed|es|ing|ation|able|er) ending, so guard words sharing a prefix stay put (specialist, realistic, finalist, emphasis-noun, raise, premise, otherwise, exercise, enterprise, ...). - Only internal identifiers renamed (private canSpecialise -> canSpecialize, test method names, local vars). No public API changed: the public surface (materialize(), Materialized* records) was already American. - Test-fixture data strings (e.g. order status "cancelled") left untouched. Build: ./mvnw verify green (all modules incl. integration); checkstyle and core javadoc clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Normalizes British → American English everywhere (javadoc, comments, docs, and internal identifiers):
recognize/optimize/finalize/serialize/materialize/behavior/color— never-ise/-isation/-our. Matches the JDK (Object.finalize,Serializable).CLAUDE.mdunder code style.How British forms were detected
Verb stems are flipped only on the
-is(e|ed|es|ing|ation|able|er)ending, so guard words that merely share a prefix are left untouched: specialist, realistic, finalist, emphasis (noun), raise, premise, otherwise, exercise, enterprise, surprise, comprise, merchandise. Plus-ourwords (behaviour, colour, honour, favour, neighbour, rigour, …) and a fixed list (analyse, labelled, modelled, acknowledgement, catalogue, …).Public API: unchanged
No published surface renamed. The public API was already American —
Array.materialize(),DecodeContext.materialize(), theMaterialized*records. Only internal identifiers changed:PrimitiveFilter.canSpecialise→canSpecialize(private, decl + call site together)specialised→specialized,materialised*) and test method namesTest-fixture data strings (e.g. order status
"cancelled") were left as-is — they are domain data, not prose.Verification
./mvnw verifygreen on the committed state — all 15 modules includingintegration(failsafe). Checkstyle clean (incl. the no-HTML-in-javadoc rule);javadoc:javadoc -pl coreproduces zero output. The only standalone-javadoc warnings are pre-existingno commentnotes in the in-housefbs-gen/proto-gengenerators, untouched here and identical onmain.🤖 Generated with Claude Code