refactor: drive ZstdStreamBuffer offsets from a MemoryLayout#60
Merged
Conversation
Replace the hardcoded ZSTD_inBuffer/ZSTD_outBuffer struct layout (magic offsets OFF_PTR/OFF_SIZE/OFF_POS and BYTES = 24) with a named StructLayout and derive the total size, field handles, and offsets from it. Field access now goes through VarHandles obtained from the layout. Behavior-preserving. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ZstdStreamBufferbacks the nativeZSTD_inBuffer/ZSTD_outBufferstructs ({ void* ptr; size_t size; size_t pos; }). It previously hardcoded the struct shape with magic numbers:This replaces those with a proper named
StructLayoutand derives everything from it:BYTESnow comes fromLAYOUT.byteSize()(same name/type/visibility, still package-accessible).VarHandles obtained from the layout (ADDRESSforptr,JAVA_LONGforsize/pos), passing base offset0L.arena.allocate(LAYOUT)).Why
Self-documenting field names instead of byte offsets, and the offsets/size can no longer drift out of sync with the declared layout.
Behavior
Behavior-preserving. The public/package surface is unchanged (
ZstdStreamBuffer(Arena),segment(),set(MemorySegment, long),size(),pos()), andsetstill zeroespos.Verification
./mvnw -pl zstd test— 261 tests, all green (streaming pathsZstdSegmentStreamTest/ZstdStreamTestexercise this struct)../mvnw javadoc:javadoc -pl zstd— zero output../mvnw -pl zstd validate(checkstyle) — clean.🤖 Generated with Claude Code