Remove Falco sidekick webui, since it uses Redis as a backend and that has issues - #629
Merged
Conversation
…t has issues Signed-off-by: Willi Carlsen <carlsenwilli@gmail.com>
Contributor
|
I can't see where this breaks anything on the consumer's end that you have marked to be as major release? |
Contributor
Author
I'm fine with lowering it to minor or patch. Which do you prefer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: We opted for removing the webui component
Okay I found that we have around 300k events stored in Redis around the clock and we do not implement TTL (can be set via the values file) on events, so I think that might be why we see crazy memory usage. Also Redis seems to behave like it has a memory leak. Also in the webui OOM's whenever I query it.
Here is my conclusions from investigations:
Solutions possible: