Feature/cleanup rbac naming - #495
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| new List<Permission> | ||
| { | ||
| new(RbacNamespace.CapabilityManagement, "manage-permissions", "", RbacAccessType.Capability), | ||
| new(RbacNamespace.Capability, "manage-permissions", "", RbacAccessType.Capability), |
There was a problem hiding this comment.
With this rename, we now have an overlap of permissions. We have capability.manage-permissions for both the global and capability access type. And with how
selfservice-api/src/SelfService/Infrastructure/Api/RBAC/RbacController.cs
Lines 822 to 824 in 4d2bf02
There was a problem hiding this comment.
If I understand your concern, this should fix it: d87f8b5
It may require some frontend work, but we will not assign a permission to a wrong scope by accident at least.
| "read-private", | ||
| "update", | ||
| "delete", | ||
| "delete-public", |
There was a problem hiding this comment.
I'm guessing this is only for local seeding? Either way, this is a change in permissions for Capability owners. This would allow them to delete public topics, something that we haven't previously allowed people unless they are cloud engineers.
There was a problem hiding this comment.
No, this is important.
It is primarily used for local seeding, but it can also be used by the 'bootstrapper' for rights in the system (the go script).
Will remove this
🌟 Changes