feat: CON-1716 Allow specifying initial DKG subnet for subnet splitting and rental#10027
Conversation
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
- Done
- No need.
- No need.
- No need.
basvandijk
left a comment
There was a problem hiding this comment.
I seem to remember there was a very similar PR that did the same recently. Or maybe I'm dreaming things.
Creating, recovering or splitting a subnet requires new key material for the nodes comprising the subnet. This key material needs to be generated by a different subnet. Until recently, this key generation was exclusively done by the NNS. Since #9782 however, it may be done by any subnet (and specifically, not the NNS).
The linked PR already updated proposals for creating and recovering subnets to optionally specify which subnet should be responsible for generating the initial key material.
This PR similarly updates the remaining two proposal types that also cause new key material to be generated, namely subnet splitting and subnet rental (which is a subnet creation).