Skip to content

feat: CON-1716 Allow specifying initial DKG subnet for subnet splitting and rental#10027

Merged
eichhorl merged 9 commits into
masterfrom
eichhorl/subnet-splitting-initial-dkg
May 5, 2026
Merged

feat: CON-1716 Allow specifying initial DKG subnet for subnet splitting and rental#10027
eichhorl merged 9 commits into
masterfrom
eichhorl/subnet-splitting-initial-dkg

Conversation

@eichhorl
Copy link
Copy Markdown
Contributor

@eichhorl eichhorl commented Apr 27, 2026

Creating, recovering or splitting a subnet requires new key material for the nodes comprising the subnet. This key material needs to be generated by a different subnet. Until recently, this key generation was exclusively done by the NNS. Since #9782 however, it may be done by any subnet (and specifically, not the NNS).

The linked PR already updated proposals for creating and recovering subnets to optionally specify which subnet should be responsible for generating the initial key material.

This PR similarly updates the remaining two proposal types that also cause new key material to be generated, namely subnet splitting and subnet rental (which is a subnet creation).

@github-actions github-actions Bot added the feat label Apr 27, 2026
@eichhorl eichhorl marked this pull request as ready for review April 27, 2026 15:02
@eichhorl eichhorl requested review from a team as code owners April 27, 2026 15:02
@eichhorl eichhorl requested a review from kpop-dfinity April 27, 2026 15:03
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

Comment thread rs/registry/canister/src/mutations/do_split_subnet.rs
Comment thread rs/registry/canister/unreleased_changelog.md Outdated
Comment thread rs/registry/canister/unreleased_changelog.md Outdated
@eichhorl eichhorl requested review from basvandijk and jasonz-dfinity and removed request for kpop-dfinity April 29, 2026 13:33
Copy link
Copy Markdown
Collaborator

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I seem to remember there was a very similar PR that did the same recently. Or maybe I'm dreaming things.

@eichhorl eichhorl enabled auto-merge April 30, 2026 18:09
@eichhorl eichhorl requested review from jasonz-dfinity and yhabib and removed request for jasonz-dfinity May 4, 2026 22:18
@eichhorl eichhorl added this pull request to the merge queue May 5, 2026
Merged via the queue into master with commit 2f5d582 May 5, 2026
37 checks passed
@eichhorl eichhorl deleted the eichhorl/subnet-splitting-initial-dkg branch May 5, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants