feat: CON-1718 Introduce default_initial_dkg_subnet_id field to state's NetworkTopology#10235
Merged
Merged
Conversation
schneiderstefan
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9782 introduced the ability to route
SetupInitialDKGrequests (caused by subnet creation/recovery/splitting) to arbitrary subnets, instead of always handling them on NNS.This was done by extending proposal payloads to create/recover/split a subnet with an optional
SubnetIdfield, to which the request should be routed.However, this approach delegates the responsibility of choosing a suitable subnet to the proposer, which is brittle and difficult to test.
Instead, this PR begins the implementation for introducing a "default initial DKG subnet" to which all
SetupInitialDKGrequests should be routed, unless specified differently by the proposal payload. In particular, this PR introduces a new field holding the ID of the default initial DKG subnet, as part of the replicated state'sNetworkTopology. For compatibility reasons, the field remainsNonefor now, until it is rolled out to all subnets.Note that it must still be possible to override the default initial DKG subnet (at least as part of the recovery proposal), for the case that the default DKG subnet is the one being recovered.