fix: canister log migration#10241
Merged
Merged
Conversation
mraszyk
commented
May 18, 2026
mraszyk
commented
May 19, 2026
mraszyk
commented
May 19, 2026
basvandijk
approved these changes
May 19, 2026
Collaborator
basvandijk
left a comment
There was a problem hiding this comment.
rs/tests changes LGTM.
michael-weigelt
approved these changes
May 19, 2026
schneiderstefan
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes canister log (data) migration:
migratedincanister.pbuf(insidelog_memory_storeinSystemState) tells if logs have been migrated from the (legacy) fieldcanister_loginSystemStateto the new fieldlog_memory_storeinSystemState:fetch_canister_logsuses the newlog_memory_storeif the feature flag is true and the store is migrated;SchedulerImpl::execute_round, for every canistercanister_loginSystemState–, migrate records, setmigratedto true);migratedto false).The
log_memory_store_featureflag is used:SchedulerImpl::execute_round;migratedfield for newly created canisters;canister_logand newlog_memory_storewhen reading logs viafetch_canister_logs(this way, flipping the flag immediately falls back to the legacycanister_log).The
migratedfield is used:log_memory_store;log_memory_store;log_memory_storecan be resized viaupdate_settings;log_memory_store.