feat: CON-1718 Introduce Proposal to set Default Initial DKG Subnet#10242
Conversation
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
- Changelog updated
- No breaking changes
- No data migration needed
- No security review needed
michael-weigelt
left a comment
There was a problem hiding this comment.
Core protocol lgtm
Background
#9782 introduced the ability to route
SetupInitialDKGrequests (caused by subnet creation/recovery/splitting) to arbitrary subnets, instead of always handling them on NNS.This was done by extending proposal payloads to create/recover/split/rent a subnet with an optional
SubnetIdfield, to which the request should be routed.Proposed Changes
The approach above delegates the responsibility of choosing a suitable subnet to the proposer, which is brittle and difficult to test.
Instead, this PR introduces a registry key holding a "default initial DKG subnet" to which all
SetupInitialDKGrequests should be routed, unless specified otherwise by the proposal payload.In particular, we:
ic-adminsupport to submit the proposal and query the current default subnetNetworkTopologybased on the value in registryNote that it must still be possible to override the default initial DKG subnet (at least as part of the recovery proposal), for the case that the default DKG subnet is the one being recovered.
Future Work
Extend the
create_subnetsystem test to include a default initial DKG subnet, once the functionality is supported by mainnet NNS canisters.