Skip to content

feat: Add VCPU type to GuestLaunchMeasurementMetadata#10245

Open
frankdavid wants to merge 1 commit into
masterfrom
frankdavid/more-metadata
Open

feat: Add VCPU type to GuestLaunchMeasurementMetadata#10245
frankdavid wants to merge 1 commit into
masterfrom
frankdavid/more-metadata

Conversation

@frankdavid
Copy link
Copy Markdown
Contributor

The PR adds a new field to GuestLaunchMeasurementMetadata to identify the VCPU type. In addition, it resolves an outstanding TODO to use named VCPU type for Turin. This is made possible by a recent change in the sev-snp-measure tool.

The PR adds a new field to GuestLaunchMeasurementMetadata to identify the VCPU type. In addition, it resolves an outstanding TODO to use named VCPU type for Turin. This is made possible by a [recent change](https://github.com/virtee/sev-snp-measure/pull/61/changes) in the sev-snp-measure tool.

Signed-off-by: David Frank <david.frank@dfinity.org>
@frankdavid frankdavid requested review from a team as code owners May 18, 2026 13:40
@github-actions github-actions Bot added the feat label May 18, 2026
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

Comment thread requirements.txt
--hash=sha256:1f1953b94cce43b08041aa7b0e804998f6d89a3d648395b40c447ecd470b1d54 \
--hash=sha256:579abfc6e9359b6bff4755a99d0704c3d2e2fd8fec16882d533192c1d5943c35
# WARNING: pip install will require the following package to be hashed.
# Consider using a hashable URL like https://github.com/jazzband/pip-tools/archive/SOMECOMMIT.zip
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants