Added test_get_alert_filter_should_return_404

source/app/blueprints/rest/v2/alerts_filters.py

@@ -30,8 +30,8 @@
 
 from app.schema.marshables import SavedFilterSchema
 from app.business.errors import ObjectNotFoundError
-from app.business.alerts_filters import alerts_filters_add
-from app.business.alerts_filters import alerts_filters_get
+from app.business.alerts_filters import alert_filter_add
+from app.business.alerts_filters import alert_filter_get
 
 
 class AlertsFiltersOperations:
@@ -48,17 +48,16 @@
 
         try:
             new_saved_filter = self._load(request_data)
-            alerts_filters_add(new_saved_filter)
+            alert_filter_add(new_saved_filter)
             return response_api_created(self._schema.dump(new_saved_filter))
 
         except ValidationError as e:
             return response_api_error('Data error', e.messages)
-
+    
     def get(self, identifier):
         try:
-            saved_filter = alerts_filters_get(identifier)
+            saved_filter = alert_filter_get(identifier)
             return response_api_success(self._schema.dump(saved_filter))
-
         except ObjectNotFoundError:
             return response_api_not_found()
 

source/app/business/alerts_filters.py

@@ -18,12 +18,15 @@
 
 from app import db
 from app.datamgmt.filters.filters_db import get_filter_by_id
+from app.business.errors import ObjectNotFoundError
 
-
-def alerts_filters_add(new_saved_filter):
+def alert_filter_add(new_saved_filter):
     db.session.add(new_saved_filter)
     db.session.commit()
 
 
-def alerts_filters_get(identifier):
-    return get_filter_by_id(identifier)
+def alert_filter_get(identifier):
+    alert_filter = get_filter_by_id(identifier)
+    if not alert_filter:
+        raise ObjectNotFoundError()
+    return alert_filter

tests/tests_rest_alerts_filters.py

@@ -19,6 +19,8 @@
 from unittest import TestCase
 from iris import Iris
 
+_IDENTIFIER_FOR_NONEXISTENT_OBJECT = 123456789
+
 
 class TestsRestAlertsFilters(TestCase):
 
@@ -221,3 +223,7 @@
         identifier = response['filter_id']
         response = self._subject.get(f'/api/v2/alerts-filters/{identifier}').json()
         self.assertEqual(filter_name, response['filter_name'])
+
+    def test_get_alert_filter_should_return_404_when_alert_filter_not_found(self):
+        response = self._subject.get(f'/api/v2/alerts-filters/{_IDENTIFIER_FOR_NONEXISTENT_OBJECT}')
+        self.assertEqual(404, response.status_code)