Fixed default proxies_dir value.#83
Closed
alehaa wants to merge 1 commit into
Closed
Conversation
The default value did not resolve to the root path, but its parent directory. Now the cache directory will be in the same directory as 'vendor', i.e. the root directory of the project.
Author
|
Is there any progress with this PR @dflydev? Can I do something to help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value did not resolve to the root path, but its parent directory. Now the cache directory will be in the same directory as 'vendor', i.e. the root directory of the project.
Note: As far as I understand this code right now, using this path may be unstable, as it highly depends on the current file location. If e.g. one would move the file, this path is not valid anymore. I would suggest to check for a constant or something similar to check, if the user provides a root path, e.g.
ROOT.