V3.2 - #305
Closed
jan-oliva wants to merge 2 commits into
Closed
Conversation
jan-oliva
commented
Aug 16, 2018
jan-oliva
commented
Contributor
- bug fix / new feature?
- BC break? yes/no
dg
reviewed
Aug 22, 2018
| public function escapeLike($value, $pos) | ||
| { | ||
| throw new Dibi\NotImplementedException; | ||
| $value = addcslashes(str_replace('\\', '\\\\', $value), "\x00\n\r\\'%_"); |
Owner
There was a problem hiding this comment.
Myslím že Firebird neescapuje lomítka. Tohle je fakt ožehavá operace a nemůžeš kopírovat kód od jinud pokud si nejsi 1000% jistý, co dělá…
Owner
There was a problem hiding this comment.
Možná by mohlo fungovat tohle z SQLite:
$value = addcslashes($this->escapeText($value), '%_\\');
return ($pos <= 0 ? "'%" : "'") . $value . ($pos >= 0 ? "%'" : "'") . " ESCAPE '\\'";Ale nemám možnost jak to ověřit, a pokud neoveříš, že to skutečně funguje jak má, tak se mi to moc nechce mergovat…
dg
pushed a commit
that referenced
this pull request
Sep 17, 2018
Owner
|
Merged |
dg
pushed a commit
that referenced
this pull request
Sep 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.