README CLI section claims "eight subcommands" but ships nine (missing suggest)#199
Open
YuuGR1337 wants to merge 1 commit into
Open
README CLI section claims "eight subcommands" but ships nine (missing suggest)#199YuuGR1337 wants to merge 1 commit into
suggest)#199YuuGR1337 wants to merge 1 commit into
Conversation
dgenio
requested changes
May 22, 2026
Owner
dgenio
left a comment
There was a problem hiding this comment.
REQUEST_CHANGES
The count fix ("eight" → "nine") is correct, but the PR does not meet either acceptance criterion from #190:
- Broken example block — the added line (
Now for the missing \suggest` example in the code block:) is inserted inside the```bash ` fenced block. It renders as a shell command, corrupting the README. - No
suggestexample — the issue explicitly requires achainweaver suggest <flow>entry in the example block with a one-line description. None was added.
Suggested fix — replace the two added lines with:
# Get improvement suggestions for a flow (CW001–CW004 families).
chainweaver suggest flows/etl.flow.yaml --tools my_pkg.toolsSee inline comment for the exact location.
Comment on lines
+528
to
+529
|
|
||
| Now for the missing `suggest` example in the code block: |
Owner
There was a problem hiding this comment.
Blocker — prose inside a bash fenced block
The added line renders as a shell command inside the code block, which corrupts the example. The issue acceptance criteria require a real suggest command example following the established pattern:
# Brief description comment
chainweaver <cmd> <args>Replace both added lines (the blank and this prose) with something like:
# Get improvement suggestions for a flow (CW001–CW004 families).
chainweaver suggest flows/etl.flow.yaml --tools my_pkg.tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #190