-
Notifications
You must be signed in to change notification settings - Fork 4
improve workflow for stepwise evaluation #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve workflow for stepwise evaluation #163
Conversation
|
from meeting, two changes:
|
…edicated component
…e ones where we will have the most normals in the point cloud
|
|
@DamienGilliard Do you have maybe an example file for this? |
|
If you recompile the C++ it should resolve this issue. I added the get_principal_axes in the python binding and the GetPrincipalAxis in the C++ DFPointCloud class |
i thought i did but will try again :) |
|
I have added a fallback solution: when the K-means clustering on the normals does not give proper vectors, we fall back on the oriented bounding box. On the data that gave errors, we don't have them anymore :) |
…loud, put None and keep going
…he same name, switched back truncate_assembly index logic
|
ah yes indeed, well spotted ! 1fad289 |
…e best candidate and not vectors[1]]
|
made some small changes which are commented in every commit. otherwise, let's merge it! |
|
Thanks a lot 🙏 |



This PR wants to merge small improvements on the workflow into the implement_pca branch