Skip to content

Conversation

@DamienGilliard
Copy link
Collaborator

This PR wants to merge small improvements on the workflow into the implement_pca branch

@DamienGilliard DamienGilliard self-assigned this Aug 11, 2025
@DamienGilliard DamienGilliard marked this pull request as draft August 11, 2025 12:18
@DamienGilliard
Copy link
Collaborator Author

DamienGilliard commented Aug 11, 2025

from meeting, two changes:

  • Instead of setting the beam ID at the CAD_segmentation step, add a component that allows to only focus on a sub-selection of the assembly.
  • with the history: output as datatree instead of dict. We can't do anything with a dict in gh

@DamienGilliard
Copy link
Collaborator Author

UPDATE: the history is now a gh_tree and a new component has been created to truncate the assembly:

Capture d'écran 2025-09-02 233034 image

@DamienGilliard DamienGilliard marked this pull request as ready for review September 9, 2025 11:22
@DamienGilliard
Copy link
Collaborator Author

DamienGilliard commented Sep 9, 2025

  • For FRTruncateAssembly, have i_truncate_index be the index of the last beam we keep (i_truncate_index = 0 --> 1 beam in assembly)

@eleniv3d
Copy link
Collaborator

eleniv3d commented Oct 2, 2025

@DamienGilliard Do you have maybe an example file for this?

@eleniv3d
Copy link
Collaborator

eleniv3d commented Oct 3, 2025

error

Do you understand this? :)

@DamienGilliard
Copy link
Collaborator Author

If you recompile the C++ it should resolve this issue. I added the get_principal_axes in the python binding and the GetPrincipalAxis in the C++ DFPointCloud class

@eleniv3d
Copy link
Collaborator

eleniv3d commented Oct 3, 2025

If you recompile the C++ it should resolve this issue. I added the get_principal_axes in the python binding and the GetPrincipalAxis in the C++ DFPointCloud class

i thought i did but will try again :)

@DamienGilliard
Copy link
Collaborator Author

I have added a fallback solution: when the K-means clustering on the normals does not give proper vectors, we fall back on the oriented bounding box. On the data that gave errors, we don't have them anymore :)

@DamienGilliard
Copy link
Collaborator Author

ah yes indeed, well spotted ! 1fad289

@eleniv3d
Copy link
Collaborator

made some small changes which are commented in every commit. otherwise, let's merge it!

@eleniv3d eleniv3d merged commit f29ec53 into implement_pca Oct 20, 2025
2 checks passed
@DamienGilliard
Copy link
Collaborator Author

Thanks a lot 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants