fix(app): keep model controls available during generation - #2958
Merged
reachjalil merged 1 commit intoJul 21, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
@reachjalil is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
reachjalil
marked this pull request as ready for review
July 21, 2026 11:33
Collaborator
Author
|
@benjaminshafii This is ready and being merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The composer previously disabled model and thinking selection for every busy session. That prevented users from preparing the next run while an ordinary response was loading. Steering remains protected because changing execution settings during an active steer can cause inconsistent behavior.
Checks
pnpm --filter @openwork/app exec bun test tests/composer-model-controls.test.ts— passed (2 tests)pnpm --filter @openwork/app test— passed (372 tests)pnpm --filter @openwork/app typecheck— passedapp-smokeeval on the Hub-assigned CDP port — passedManual verification
Not run — the isolated merge-readiness profile was fresh and had no onboarded workspace or usable model, so a real generation/steer journey was unavailable.
Reviewer steps:
Risk
Low and UI-local. No API, IPC, persistence, or model request shape changes.