fix(desktop): preserve non-mac branding behavior - #2962
Merged
reachjalil merged 1 commit intoJul 21, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
|
@reachjalil is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
reachjalil
marked this pull request as ready for review
July 21, 2026 12:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
This is a follow-up to #2960. That PR fixed the macOS menu-bar label by updating
process.titleand Electron's application name before rebuilding the native menu. Its initial helper also expanded the liveapp.setName()call to Windows and Linux, although those platforms did not require it.Startup behavior remains unchanged on every platform: Electron's application name is still initialized from branding. During live updates, macOS keeps the new native-name sequence while Windows and Linux retain their previous menu/window update path. Windows shortcut and taskbar identity registration are unchanged.
Verification
./bin/openwork-hub run desktop macos-brand-menu-platform-safety -- pnpm --dir apps/desktop exec node --test electron/brand-app-name.test.mjs electron/brand-icon-windows.test.mjs— passed; 13 tests./bin/openwork-hub run desktop macos-brand-menu-platform-safety -- pnpm --filter @openwork/desktop typecheck:electron— passed./bin/openwork-hub run desktop macos-brand-menu-platform-safety -- pnpm --filter @openwork/desktop check:electron— passed; 56 renderer methods covered./bin/openwork-hub run desktop macos-brand-menu-platform-safety -- pnpm --filter @openwork/desktop test— passed; 103 tests passed, 1 platform-specific test skippedopenwork-tests— passed on Ubuntu 22.04 and macOS 14i18n-audit— passedRisks and remaining checks