Skip to content

fix(desktop): preserve non-mac branding behavior - #2962

Merged
reachjalil merged 1 commit into
different-ai:devfrom
reachjalil:feature/macos-brand-menu-platform-safety
Jul 21, 2026
Merged

fix(desktop): preserve non-mac branding behavior#2962
reachjalil merged 1 commit into
different-ai:devfrom
reachjalil:feature/macos-brand-menu-platform-safety

Conversation

@reachjalil

@reachjalil reachjalil commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • scope live Electron app-name mutation to macOS, where it is required for the branded native application menu
  • preserve the pre-existing Windows and Linux live branding sequence
  • add a Windows regression test that fails if a live name update mutates the process title or Electron app name

Context

This is a follow-up to #2960. That PR fixed the macOS menu-bar label by updating process.title and Electron's application name before rebuilding the native menu. Its initial helper also expanded the live app.setName() call to Windows and Linux, although those platforms did not require it.

Startup behavior remains unchanged on every platform: Electron's application name is still initialized from branding. During live updates, macOS keeps the new native-name sequence while Windows and Linux retain their previous menu/window update path. Windows shortcut and taskbar identity registration are unchanged.

Verification

  • ./bin/openwork-hub run desktop macos-brand-menu-platform-safety -- pnpm --dir apps/desktop exec node --test electron/brand-app-name.test.mjs electron/brand-icon-windows.test.mjs — passed; 13 tests
  • ./bin/openwork-hub run desktop macos-brand-menu-platform-safety -- pnpm --filter @openwork/desktop typecheck:electron — passed
  • ./bin/openwork-hub run desktop macos-brand-menu-platform-safety -- pnpm --filter @openwork/desktop check:electron — passed; 56 renderer methods covered
  • ./bin/openwork-hub run desktop macos-brand-menu-platform-safety -- pnpm --filter @openwork/desktop test — passed; 103 tests passed, 1 platform-specific test skipped
  • GitHub Actions openwork-tests — passed on Ubuntu 22.04 and macOS 14
  • GitHub Actions i18n-audit — passed

Risks and remaining checks

  • A native Windows runtime was not available locally. Windows behavior is covered through dependency-injected name tests and the existing taskbar/shortcut suite.
  • No packaged application build was run.
  • This follow-up does not change the macOS branch exercised end to end in fix(desktop): apply branded name to macOS menu bar #2960.
  • Vercel app/Den preview statuses require deployment authorization for the fork; the applicable landing preview passed and diagnostics was skipped as unaffected.

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openwork-landing Ready Ready Preview, Comment, Open in v0 Jul 21, 2026 12:33pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
openwork-diagnostics Skipped Skipped Jul 21, 2026 12:33pm

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@reachjalil is attempting to deploy a commit to the Different AI Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
vercel Bot temporarily deployed to Preview – openwork-diagnostics July 21, 2026 12:32 Inactive
@reachjalil
reachjalil marked this pull request as ready for review July 21, 2026 12:52
@reachjalil
reachjalil merged commit 28d9ad6 into different-ai:dev Jul 21, 2026
7 of 10 checks passed
@reachjalil
reachjalil deleted the feature/macos-brand-menu-platform-safety branch July 21, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant