Skip to content

fix(mcp): redact provider payloads at diagnostic boundaries - #2997

Open
reachjalil wants to merge 1 commit into
different-ai:devfrom
reachjalil:feature/mcp-diagnostic-redaction
Open

fix(mcp): redact provider payloads at diagnostic boundaries#2997
reachjalil wants to merge 1 commit into
different-ai:devfrom
reachjalil:feature/mcp-diagnostic-redaction

Conversation

@reachjalil

Copy link
Copy Markdown
Collaborator

Summary

  • strip provider-declared message and data fields before diagnostics cross HTTP response or structured-log boundaries
  • rebuild the public message from trusted diagnostic fields
  • preserve internal provider evidence for agent-facing recovery while preventing provider-controlled secrets from reaching clients or logs

Verification

  • bun test --conditions development test/external-mcp-diagnostics.test.ts — 79 passed, 0 failed
  • bun test --conditions development test/mcp-connections-tools.test.ts — 16 passed, 0 failed
  • pnpm --filter @openwork-ee/den-api build — passed

Regression proof

Before this fix, the tools-route suite failed 2 tests and emitted provider-catalog-secret in both the response diagnostic and structured error log. The new boundary test also fails on the base revision.

Risk

Low and fail-closed. Internal diagnostics retain bounded provider evidence; only untrusted response/log projections remove provider payloads. No authentication, protocol, size, or routing policy is relaxed.

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openwork-landing Ready Ready Preview, Comment, Open in v0 Jul 22, 2026 10:50am

@vercel
vercel Bot temporarily deployed to Preview – openwork-diagnostics July 22, 2026 10:49 Inactive
@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@reachjalil is attempting to deploy a commit to the Different AI Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant