fix(app): reveal the full skill description on hover - #3091
Closed
benjaminshafii wants to merge 1 commit into
Closed
fix(app): reveal the full skill description on hover#3091benjaminshafii wants to merge 1 commit into
benjaminshafii wants to merge 1 commit into
Conversation
Skill descriptions are clipped at two lines by line-clamp-2 with no title or tooltip, so the full text was unreachable from the extensions list. Wrap the clipped text in the existing Tooltip primitive. Reported via OpenWork feedback (fangrenzsf-creator, Jun 14).
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reported via OpenWork feedback (fangrenzsf-creator, Jun 14, v0.16.2, Windows), in Chinese: Skills list descriptions are unreadable when long.
Investigation — the reported symptom was NOT reproducible
The user said the text does not wrap and forces a horizontal scrollbar. That is not what the code does:
extension-card.tsx:175usesline-clamp-2— the text wraps, then clips at 2 lines. Nowhitespace-nowrap, notruncate, nooverflow-xscroller, and the grid tracks areminmax(0,1fr)so content cannot widen a track.settings/pages/skills-view.tsx) is dead code ondev— unreferenced since 820d00a. Its skill name hadtruncatewithoutmin-w-0, which is the real source of their horizontal scrollbar, but that file no longer ships. The live card already hasmin-w-0 break-words.The genuine remaining gap
Clipped text had no
titleand no tooltip, so the full description was unreachable from the list — it existed only in the detail modal. That matches the user's own suggestion #3.How
Wrap the clipped
<p>in the existingTooltipprimitive (components/ui/tooltip.tsx, Base UI).TooltipProvideris already mounted app-wide atindex.react.tsx:43.TooltipContentalready hasmax-w-xs. 5 insertions, 1 deletion.Tradeoff (please weigh in)
The tooltip is unconditional — it shows even when the description is short enough not to clip, duplicating visible text. Detecting actual clipping needs DOM measurement, which is disproportionate here. Skill descriptions are characteristically long (they are LLM-facing trigger text, which is why this was reported at all), so in practice it nearly always adds information. Happy to gate it on a measured overflow check if you'd rather.
Tests run
Not done
No fraimz/CDP run.