test(den-web): assert install-link error intent instead of stale copy - #3107
Merged
Conversation
The expired-install-link assertion pinned copy that no longer shipped, so the suite failed on a clean checkout. Assert the actual contract (no raw API error code leaks, the message names the link, expiry, and who to ask) so wording can improve without breaking the test.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ee/apps/den-web/tests/install-errors.test.tsfails on a clean checkout ofdev. The assertion pinned copy that no longer ships:This install link is expired or no longer available. Ask your organization admin for a fresh link.This install link has expired or was replaced. Ask your workspace admin for a fresh one from the Members page.The shipped copy is the better one (it names the Members page), so the test was stale, not the product.
Fix
Assert the actual contract instead of a brittle literal: the message must not leak the raw API error code, and must name the link, the expiry, and who to ask. Wording can now improve without breaking the test.
Verification
Found while auditing unrelated work — this one is a pure test fix and unblocks a red suite on
dev.