fix(den-web): describe the real macOS installer steps - #3121
Merged
Conversation
Step 2 told macOS users to drag the app into Applications. The disk image contains a single item, Install OpenWork, and no Applications shortcut, so there is nothing to drag: you double-click that installer and choose Install. Also stop attributing the installer's work to the app. The downloaded file is the installer, it is what the OS warns about, and it is what installs the app and opens the browser to approve this computer. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of the org install guide told macOS users to "Drag OpenWork into Applications, then open it". That is not what happens.
Why it was wrong
The published disk image contains exactly one item —
Install OpenWork.app— and no Applications symlink.apps/installer/scripts/dmg-layout.mjspositions that single icon, and mounting the realv0.18.1artifact confirms it: the volume root holds the installer app and nothing else. So there is nothing to drag anywhere. The user double-clicks the disk image, double-clicksInstall OpenWork, and chooses Install in the window that appears (apps/installer/src/ui-html.tsrenders that primary button). The installer then installs the app.The same mix-up ran through the neighbouring copy, which credited the app with the installer's work: the OS warning is about opening the installer, and it is the installer that opens the browser to approve the computer.
What changed
appNameon purpose: the generic installer's bundle is alwaysInstall OpenWork, and organization branding only changes the installer's window title at runtime, so a white-labelled org would otherwise be told to look for an icon that does not exist..exeis the installer and it has an Install button, not a prompt chain.The
Open {appName}button is untouched and still correct. It navigates toopenwork://connect?code=…, a scheme owned solely by the desktop app (app.setAsDefaultProtocolClient("openwork")inapps/desktop/electron/main.mjs); the installer registers no scheme at all and can only openhttp/httpsoutward. That deeplink therefore cannot and should not address the installer, which is exactly why the button sits behind "Already have {appName} on this computer?".Testing
pnpm typecheckinee/apps/den-web— passes.dmgwith the double-click-Install steps and the Windows branch shows the.exewith the SmartScreen noteMade with Cursor