test(evals): drop the reopen/persistence requirement from the core flow - #3123
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
evals/flows/core-flow.flow.mjsis the canonical smoke proof referenced by AGENTS.md and thefraimzskill. Its 4th step — "User closes and reopens the app; the session survives" — fails on cleandev. I hit it while validating an unrelated series and then reproduced it twice, in two freshly provisioned Linux sandboxes, with a real model:It is a flow defect, not a product bug
The step reloads the renderer and then asserts:
session.list_sessions(apps/app/src/react-app/domains/session/control/session-control-actions.ts) just reads the in-memorysessionsByWorkspaceIdstore. The flow waits for the action to be registered, not for that store to be hydrated after the reload — so it races hydration and can legitimately observe an empty list. The failure message ("not persisted") actively points the reader at the wrong layer.Change
Removes that step, so the canonical flow is: open the app → create a task → write a message → get a response. Title and header comment updated to match, with a short note recording why reopen/persistence was dropped and what proving it properly would require (wait for store hydration, not action registration). Also corrects the two places that described the old step:
.opencode/skills/fraimz/SKILL.mdand.opencode/commands/fraimz.md.New shape:
Verification
evals/voiceovers/core-flow.mddoes not exist, so there is no narration to drift. CheckedAGENTS.mdandevals/README.md— no other stale step-level prose. No remaining references tocore-flow-04orsession intact.If we want session persistence proven, it belongs in a dedicated flow that waits for hydration — happy to follow up.