fix(app): restore the Extensions typecheck - #3192
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
#3184 left ManageInDenButton referencing openDesktopUrl, t, and ArrowUpRight without imports. The button is dead code today, but its i18n key exists, so keep the teammate's in-progress path rather than deleting it. The Extensions inventory initialFilter was also inferred as a bare string before being passed to mcpView. Type it as ExtensionsInventoryFilter so dev's @openwork/app typecheck stops failing for everyone.
benjaminshafii
force-pushed
the
fix/app-typecheck-extensions
branch
from
July 27, 2026 14:56
3b205cb to
e783272
Compare
benjaminshafii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@openwork/apptypecheck after feat(extensions): unify Extensions inventory and retire Connect tab #3184 by importing the missingopenDesktopUrl,t, andArrowUpRightsymbols used byManageInDenButton.ManageInDenButtonanddenManageConnectionsUrlintact because the button is currently unrendered, but itsconnect.manage_in_den_webi18n key exists.initialFilterasExtensionsInventoryFilterinstead of allowing it to infer as a barestring.Exact errors fixed
apps/app/src/react-app/domains/settings/cloud/agent-access-card.tsx:Cannot find name openDesktopUrl.apps/app/src/react-app/domains/settings/cloud/agent-access-card.tsx:Cannot find name t.apps/app/src/react-app/domains/settings/cloud/agent-access-card.tsx:Cannot find name ArrowUpRight.apps/app/src/react-app/domains/settings/pages/extensions-view.tsxline ~77:TS2345becauseinitialFilter: stringwas not assignable toExtensionsInventoryFilter.apps/app/src/react-app/domains/settings/pages/extensions-view.tsxline ~102: sameTS2345for the secondmcpView(mcpRouting)call.Verification
pnpm --filter @openwork/app typecheck— passed with 0 TypeScript errors.pnpm --filter @openwork/app test— 456 pass, 0 fail, 1269 expect() calls across 86 files.Runtime proof
This is a compile-fix with no runtime path change:
ManageInDenButtonis currently not rendered anywhere, so there is no user-visible behavior change. No end-to-end frame proof accompanies this PR for that reason.