feat(helm): tls-chain-check test hook that fails on incomplete certificate chains - #3213
Open
benjaminshafii wants to merge 1 commit into
Open
feat(helm): tls-chain-check test hook that fails on incomplete certificate chains#3213benjaminshafii wants to merge 1 commit into
benjaminshafii wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OmarMcAdam
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
A customer ingress served a leaf-only TLS chain; browsers masked it, the engine failed with
UNABLE_TO_VERIFY_LEAF_SIGNATURE, and it cost the POC three weeks.helm testnow catches it at deploy time.Changes
templates/tests/tls-chain-check.yaml:helm.sh/hook: testPod, emitted only wheningress.enabled+ingress.tls+tests.tlsChainCheck.enabled; counts certificates served per ingress host viaopenssl s_client -servername; fails with an actionable message naming the fullchain fix and the engine failure mode.values.yaml: documentedtests.tlsChainCheckblock (enabled, overridable image for air-gapped clusters).tests/tls-chain-check.sh: render harness asserting inclusion/exclusion and the failure-message string, following the existing tests/*.sh pattern.Tests run
packaging/helm/openwork-ee/tests/tls-chain-check.sh— passedpackaging/helm/openwork-ee/tests/custom-ca.sh— passed (shared helpers unaffected)helm lint packaging/helm/openwork-ee— 1 chart linted, 0 failed (helm v4.2.2)No app UI surface — evidence is the harness/lint output above; fraimz not applicable.