feat(den-api): members can create plugins and cloud skills (skill-sharing posture slice) - #3411
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…org-wide publishing admin-only
benjaminshafii
force-pushed
the
feat/member-plugin-create
branch
from
August 1, 2026 15:25
9127fb4 to
0367302
Compare
Member
Author
|
Eval run (spec lane) on this branch — 2026-08-01T20:31:22Z |
There was a problem hiding this comment.
Warden security clearance: clear. No new security issues found in this diff (03673023a5f6280d90874e41d6046acc3beb6608). Automated clearance satisfies the required-review gate only — a human still reviews and merges. Analysis run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Members (not just admins/owners) can now create plugins and cloud skills — the
create-skillchat flow works for everyone in the org. Slice of the Grant-Native Skill Sharing program (spec on #3410,prds/skill-sharing/grant-native-skill-sharing.md); pairs with #3410's index fix, which makes a created skill immediately usable by its creator.hasPluginArchCapabilitywas a stub returningisOrgAdminfor every capability (access.ts:101-103). Now:plugin.create,config_object.createmarketplace.create,connector_account.create,connector_instance.createDeliberately NOT opened to members (each gated explicitly):
orgWide: trueon bundles and on access grants now requires admin (route +createPluginBundle+createResourceAccessGrant). Without this, member-create would silently ship theshare_orgposture; that stays a program decision (P4).importGithubPluginMcps) and connector discovery apply (applyGithubConnectorDiscovery) — both also sat behindplugin.create; pinned to admin at the store level so this PR changes exactly two surfaces:POST /v1/pluginsandPOST /v1/config-objects.Member/team-scoped grants by a plugin's own manager keep today's semantics. Marketplace publishing already requires marketplace
editor(unchanged). OpenAPIaudiencedocs updated for the two endpoints (documentation-only field — verified unused by enforcement/clients).Tests (commands + results)
New suite
test/plugin-system-member-create.test.ts(real MySQL): member creates bundle+skill and holdsmanager; memberorgWidebundle → 403 with zero rows written; member publish to uneditable marketplace → rejected, no rows; member manager grants another member ✅ but org-wide ❌; admin org-wide end-to-end ✅; member GitHub import → 403 pre-fetch; member discovery apply → 403.Per program-owner decision, proof is spec acceptance suites (no fraimz); reproduce with the commands above (MySQL at 127.0.0.1:3306, suite DB via
pnpm --filter @openwork-ee/den-db db:push).