feat(den-api): P2 share verbs — share-plugin builtin, create-skill share offer, duplicate-plugin 409 - #3422
Merged
Merged
Conversation
…ll share offer, duplicate-plugin 409 (skill-sharing P2)
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Warden security clearance: clear. No new security issues found in this diff (7b4ea066cc2d88003516353ee71b86bb5ad49332). Automated clearance satisfies the required-review gate only — a human still reviews and merges. Analysis run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Phase 2 of the Grant-Native Skill Sharing program (spec:
prds/skill-sharing/grant-native-skill-sharing.md, P2 results recorded in-doc). Sharing becomes a chat verb; a share is one grant row.share-plugin(skill:share-plugin): resolve the person (om_…) or team (tem_…) viagetOrg— never invent ids — thenpostPluginsAccesswithrole: viewerby default (editor only on explicit ask; org-wide relayed as admin-only), verify viagetPluginsAccess, report the recipient can use the skill immediately (P1 index).create-skillnow offers to share after creation, and on409 duplicate_pluginsteers to updating the existing skill instead of duplicating.409 duplicate_plugincontaining the existing plugin id (PluginArchRouteFailure). Archived names reusable; different creators unaffected. Admin GitHub re-imports of an identical name now 409 — accepted, aligns with the program's dedup goal.store.ts:1887,1895).Tests (commands + results)
The wire spec now proves the whole story end-to-end on the real MCP surface: member creates a skill → uses it immediately → second member denied → creator says 'share with them' (one viewer grant) → second member discovers and executes it (
marketplace: null) → recipient cannot re-share (403).Proof format: spec acceptance suites per program-owner decision.