polish(den-web): library matches the approved Paper design — and the spec now pins fidelity - #3430
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
Photo roll — p3-library✅ 2/2 frames passed · 0 failed · 0 unvalidated · 5 expectations passed · 0 failed 1. A gradient hero card titled Library contains the description text inside it
2. A narrow mobile layout shows library cards in a single column
Roll created 2026-08-02T14:29:28.601Z · Source: |
benjaminshafii
enabled auto-merge (squash)
August 2, 2026 14:32
auto-merge was automatically disabled
August 2, 2026 15:12
Pull request was closed
benjaminshafii
enabled auto-merge (squash)
August 2, 2026 15:13
Deploying openwork with
|
| Latest commit: |
4c83528
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c31b3a1d.openwork.pages.dev |
| Branch Preview URL: | https://feat-p3-library-polish.openwork.pages.dev |
…search placement, card/chip fidelity; spec now pins design
benjaminshafii
force-pushed
the
feat/p3-library-polish
branch
from
August 2, 2026 15:25
4c83528 to
5c955e5
Compare
There was a problem hiding this comment.
Warden security clearance: clear. No new security issues found in this diff (5c955e52f95030dfa094da2201b66791f429e4e7). Automated clearance satisfies the required-review gate only — a human still reviews and merges. Analysis run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What
Follow-up to #3429 after design review: the shipped library drifted from the approved canvas (Paper pages "PR3 — Member library placement" + "Mobile treatment"). Fixed, exactly per the canvas:
The process fix that matters
library-view.slow.test.tsnow pins design fidelity, not just function: DOM-order assertions (description renders inside the hero and before the tabs; search precedes tabs; no "component" counts inside cards) + tightened vision expectations ("hero contains the description inside it", "small provenance pills with no component counts", "hero is short on mobile"). 2 runs green, 5/5 vision expectations. Drift of this kind now fails the spec instead of reaching a human eye.Tests
Before/after: #3429's photo-roll comment is the before; the sticky roll below is the after.