Skip to content

polish(den-web): library matches the approved Paper design — and the spec now pins fidelity - #3430

Merged
benjaminshafii merged 1 commit into
devfrom
feat/p3-library-polish
Aug 2, 2026
Merged

polish(den-web): library matches the approved Paper design — and the spec now pins fidelity#3430
benjaminshafii merged 1 commit into
devfrom
feat/p3-library-polish

Conversation

@benjaminshafii

Copy link
Copy Markdown
Member

What

Follow-up to #3429 after design review: the shipped library drifted from the approved canvas (Paper pages "PR3 — Member library placement" + "Mobile treatment"). Fixed, exactly per the canvas:

  • Hero: description + "Member library" badge INSIDE the DashboardPageTemplate (was a floating paragraph below); compact hero below md so it stops dominating phones.
  • Layout order: hero → constrained search (max-w-[340px], icon) → tabs → grid (search was a full-width orphan under the tabs).
  • Cards: canvas anatomy — name, 2-line description, then small provenance pills directly after; the top-right "N components" label (never in the design) removed; no bottom-pinned chips.
  • Chips: 11px pills with exact canvas tones; long team/catalog values truncate instead of wrapping into blobs.
  • Tab scrollbar hidden on mobile.

The process fix that matters

library-view.slow.test.ts now pins design fidelity, not just function: DOM-order assertions (description renders inside the hero and before the tabs; search precedes tabs; no "component" counts inside cards) + tightened vision expectations ("hero contains the description inside it", "small provenance pills with no component counts", "hero is short on mobile"). 2 runs green, 5/5 vision expectations. Drift of this kind now fails the spec instead of reaching a human eye.

Tests

den-web tsc + next build — clean
library-view.slow.test.ts — 2× green (17.7s / 18.8s), roll 2 frames, vision 5/5
evals typecheck — clean

Before/after: #3429's photo-roll comment is the before; the sticky roll below is the after.

@vercel

vercel Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openwork-app Ready Ready Preview Aug 2, 2026 3:27pm
openwork-den Ready Ready Preview Aug 2, 2026 3:27pm
openwork-den-worker-proxy Ready Ready Preview Aug 2, 2026 3:27pm
openwork-diagnostics Ready Ready Preview Aug 2, 2026 3:27pm
openwork-landing Ready Ready Preview, v0 Aug 2, 2026 3:27pm

@benjaminshafii

Copy link
Copy Markdown
Member Author

Photo roll — p3-library

2/2 frames passed · 0 failed · 0 unvalidated · 5 expectations passed · 0 failed

1. A gradient hero card titled Library contains the description text inside it

  • PASS A gradient hero card titled Library contains the description text inside it — The blue gradient hero card visibly contains “Library” and “Everything you can use in chat — yours, shared with you, from your teams, and org-wide.”
  • PASS Plugin cards show name, description and small provenance pills with no component counts — Visible cards show titles, description text, and pills such as “Shared by Casey Spec,” “Team: Spec Library Provenance Team…,” and “Catalog: Anthropic Knowledge Work Plugins”; no component counts are shown.

A gradient hero card titled Library contains the description text inside it

2. A narrow mobile layout shows library cards in a single column

  • PASS A narrow mobile layout shows library cards in a single column — The narrow viewport displays the AAA, customer-support, and data cards stacked vertically.
  • PASS Provenance chips wrap and remain readable — The “Shared by Casey Spec” and “Team: Spec Library Provenance…” chips appear on separate readable rows.
  • PASS the hero is short and does not dominate the screen — The blue Library hero is compact, with the search, tabs, and multiple cards visible below it.

A narrow mobile layout shows library cards in a single column


Roll created 2026-08-02T14:29:28.601Z · Source: evals/results/rolls/2026-08-02T14-29-28-600Z-p3-library/roll.json · Repro: pnpm --dir evals run publish:pr -- --pr 3430 --roll 2026-08-02T14-29-28-600Z-p3-library

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 2, 2026

Copy link
Copy Markdown

Deploying openwork with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4c83528
Status: ✅  Deploy successful!
Preview URL: https://c31b3a1d.openwork.pages.dev
Branch Preview URL: https://feat-p3-library-polish.openwork.pages.dev

View logs

…search placement, card/chip fidelity; spec now pins design

@diff-warden diff-warden Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warden security clearance: clear. No new security issues found in this diff (5c955e52f95030dfa094da2201b66791f429e4e7). Automated clearance satisfies the required-review gate only — a human still reviews and merges. Analysis run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant