fix(app): sidebar Library row icon weight matches its neighbors (70% idle, full on hover/active) - #3436
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
benjaminshafii
enabled auto-merge (squash)
August 2, 2026 19:35
![diff-warden[bot]](https://avatars.githubusercontent.com/u/118544361?s=60&v=4){kind=small}
There was a problem hiding this comment.
Warden security clearance: clear. No new security issues found in this diff (35c0466f8c0272f8466d8d3af26d49f380c65ccc). Automated clearance satisfies the required-review gate only — a human still reviews and merges. Analysis run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3434 from design review: the sidebar header's Search row idles at
text-sidebar-foreground/70, but the Library destination row passed no class — its Puzzle icon+label rendered full-strength black directly beneath a muted neighbor. One-class fix onSidebarDestination; hover/active still restore full strength via the base button'sdata-active/hover variants, so the active state is unchanged.Tests: extensions-sidebar-header suite extended to pin the idle weight (9 tests green), apps/app typecheck clean. Visual-only change; nightly desktop spec covers the surface.