STY: pep8

[CJ-Wright]

I don't think this passes flake8 yet, we should fix that.

[RomanMatthew]

Has this been resolved @CJ-Wright ?

[sbillinge]

Hahaha, I think he means for you to make it pass flake8. This is much easier if you are using pycharm or another IDE that does this automatically. I can show you tomorrow.

On Mon, Jul 8, 2019 at 5:10 PM RomanMatthew ***@***.***> wrote: Has this been resolved @CJ-Wright <https://github.com/CJ-Wright> ? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABAOWUKLQH5CCXUGHZQ4EQDP6OULRANCNFSM4ELDIYNA> .

-- ---- Prof. Simon Billinge Applied Physics & Applied Mathematics Columbia University 500 West 120th Street Room 200 Mudd, MC 4701 New York, NY 10027 Tel: (212)-854-2918 (o) 851-7428 (lab) Condensed Matter Physics and Materials Science Dept. Brookhaven National Laboratory P.O. Box 5000 Upton, NY 11973-5000 (631)-344-5661 email: sb2896 at columbia dot edu home: http://thebillingegroup.com

[CJ-Wright]

I think we should just run black and be done with it.

[sbillinge]

I’m ok with that.

On Mon, Jul 8, 2019 at 5:15 PM Christopher J. Wright < ***@***.***> wrote: I think we should just run black and be done with it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABAOWUI3FWA6UXDS2TUJFELP6OU55ANCNFSM4ELDIYNA> .

-- Prof. Simon Billinge Applied Physics & Applied Mathematics Columbia University 500 West 120th Street Room 200 Mudd, MC 4701 New York, NY 10027 Tel: (212)-854-2918 (o) 851-7428 (lab) Condensed Matter Physics and Materials Science Dept. Brookhaven National Laboratory P.O. Box 5000 Upton, NY 11973-5000 (631)-344-5661 email: sb2896 at columbia dot edu home: http:// <http://nirt.pa.msu.edu/>bgsite.apam.columbia.edu/

[chloeann95]

So are we still wanting to do this? My pycharm automatically flags flake8 style violations but I have no idea how to get it to automatically reformat. We use something at my work called yapf for pep8 but not sure if it does flake8. It would also be rather time consuming to achieve manually as there's a large number of violations on almost every file.

[sbillinge]

you can do it in pycharm by clicking on something with a yellow underline that is a pep8 violation (for example, a list with no space after the comma) , waiting for the balloon to appear on the left and clicking on it. It gives options for applying pep8 linting.

IMPORTANT....this will update many files, so do it on a clean branch with no other edits and then get that branch merged without having too many other branches open, because it can raise all kinds of conflicts the first time you do it.

Later, do it on each branch (before merging so the badness doesn't build up. To protect against this we could include running flake8 or black as part of the CI