added DS_store to ignore and test edit#49
Merged
Conversation
sbillinge
reviewed
Nov 17, 2022
sbillinge
left a comment
sbillinge
left a comment
Contributor
There was a problem hiding this comment.
Great job. I know this is WIP and no review requested but I just looked in. It all looks good.
To make more edits, don't close and reopen the PR but just check out your local branch of name usage_doc, make edits, add, commit and push them and they will miraculously appear here and I will get notified.
Author
|
@sbillinge I added both the changes to the documentation and help under the same branch, I was a bit unsure about this. For the documentation it was added under the index file - it was already written explicitly in the quickstart.rst that pdfmorph file1 file2 just plots and does no morphing (line 57-61). |
sbillinge
changed the title
Contributor
|
Thanks @sarafrank95 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45