GH action to build and deploy docs V2#92
Closed
cadenmyers13 wants to merge 4 commits into
Closed
Conversation
cadenmyers13
commented
May 20, 2024
| @@ -13,7 +13,7 @@ | |||
| import sys | |||
| import os | |||
| sys.path.insert(0, os.path.abspath('../..')) | |||
Contributor
Author
There was a problem hiding this comment.
does this need to be changed to .abspath('../../..') ?
Contributor
There was a problem hiding this comment.
In general we are moving from sys.path to pathlib, so whenever we touch code and have the opportunity to do that, let's do that. I can't answer you question without some effort, but if you can try and make sure all the docs build correctly and all the links work, you can probably figure it out.
Summary:
yes, everywhere you can, replace sys.path with pathlib.Path syntax and (b) build the docs and make sure the links all work.
Contributor
|
replaced by #93 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #52
Used code from
docs.ymlindiffpy.utils.