Skip to content

Files for pre-commit#74

Merged
sbillinge merged 4 commits into
diffpy:mainfrom
cadenmyers13:precommit
May 31, 2024
Merged

Files for pre-commit#74
sbillinge merged 4 commits into
diffpy:mainfrom
cadenmyers13:precommit

Conversation

@cadenmyers13

@cadenmyers13 cadenmyers13 commented May 31, 2024

Copy link
Copy Markdown
Contributor

closes #63

adding .flake8, .isort.cfg, .pre-commit-config.yaml, and prevent_commit_to_main.sh

@sbillinge sbillinge merged commit a629566 into diffpy:main May 31, 2024
@sbillinge

Copy link
Copy Markdown
Contributor

@cadenmyers13 @Sparks29032 I merged this as it is what was requested in the original issue (@cadenmyers13 I didn't see a "Closes #" so please close that manually if it is there).

@Sparks29032 I would be interested in revisiting this to get rid of the no-commit-to-main.sh local file and maybe switch to pre-commit.ci.

We can make a new issue for this migration and when it is sorted, perhaps @cadenmyers13 can make the changes on pdfmorph and labpdfproc.

In the longer term I would like to make these mods in a cookiecutter of our own so all new packages we create all have everything set up nicely.

@cadenmyers13

Copy link
Copy Markdown
Contributor Author

@sbillinge This closes #63 (see edit above). I dont think i have access to manually close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add pre-commit github workflow

2 participants