Make clippy a bit happier#104
Merged
Merged
Conversation
emilk
commented
Feb 4, 2021
| let axis2 = position2 * self.local_axis2; | ||
| let delta_rot = | ||
| Rotation::rotation_between_axis(&axis1, &axis2).unwrap_or(Rotation::identity()); | ||
| Rotation::rotation_between_axis(&axis1, &axis2).unwrap_or_else(Rotation::identity); |
Contributor
Author
There was a problem hiding this comment.
maybe .unwrap_or_default() would be even better?
Member
There was a problem hiding this comment.
I like the more explicit .unwrap_or_else(Rotation::identity) better. The docs about Default states:
Sometimes, you want to fall back to some kind of default value, and don't particularly care what it is [...]
Since we do care about the fact we get the identity, it feels like Default isn't appropriate.
26 tasks
Member
|
Everything is OK. Thanks! |
jamespohalloran
pushed a commit
to jamespohalloran/rapier
that referenced
this pull request
Apr 26, 2025
FeatureId support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did a quick pass fixing some things that clippy complained about. Nothing major. I there is anything you disagree with I am happy to revert.