Fix invalid sample count#271
Closed
jsatka wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Fixed in commit for testbed to use bevy 0.6 |
tomo0613
pushed a commit
to tomo0613/rapier
that referenced
this pull request
Jun 21, 2026
…e#370) This implements the frame transformation capabilities requested in issue dimforge#271, allowing users to set joint frames after joint creation via: - setFrameX1() / setFrameX2() for rotation frames - setLocalFrame1() / setLocalFrame2() for full frame (anchor + rotation) These methods enable more flexible joint configuration in physics simulations, particularly for use cases like VistaKine where joint frames need adjustment after initial setup. Fixes dimforge#271
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #261
Valid sample counts are 1 and 4 in WebGPU specification - 6.1.1 Texture Creation.
Sample counts are checked by wgpu (both 0.7.1 and 0.12.0) here: https://github.com/gfx-rs/wgpu/blob/v0.12/wgpu-core/src/command/render.rs#L865