Use gethostname on Windows#4
Use gethostname on Windows#4Jake-Shadle wants to merge 8 commits intodjc:masterfrom Jake-Shadle:master
Conversation
|
This should also fix #3 as it removes the |
|
I‘d like to see this change applied; GetComputerName returns the truncated netbios name which is not necessarily the same as the system received from DHCP for DNS. I’d use ComputerNamePhysicalDnsHostname though because it probably does less DNS calls, and perhaps also GetComputerNameExW instead of *A because DNS can contain Unicode probably. At least that’s what Python does in socket.gethostname and I believe Python receive a good deal of real world testing here. |
|
Sorry guys. I have no time and interest in Rust right now. This project is going to Abandoned status. |
|
@fengcen in that case I wouldn't mind taking over ownership of this crate since I work in rust full time now. 🙂 |
|
@Jake-Shadle I did gethostname.rs meanwhile. |
|
Cool, guess we can just use that instead, thanks! |



The Windows implementation was using
GetComputerNameeven thoughgethostnameis available on Windows, so I updated to the latest winapiinstead of winutil.
Also added CI.