Skip to content

Proto#121

Merged
djc merged 5 commits intomainfrom
proto
Feb 19, 2026
Merged

Proto#121
djc merged 5 commits intomainfrom
proto

Conversation

@djc
Copy link
Owner

@djc djc commented Feb 19, 2026

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request extracts SSH protocol parsing and message handling code into a separate oxish-proto crate to improve modularity and code organization.

Changes:

  • Created new oxish-proto crate with protocol message types, encoding/decoding traits, and error types
  • Refactored oxish crate to use the new oxish-proto dependency, updating imports and error handling
  • Consolidated error types by moving protocol-related errors into ProtoError in the proto crate

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Cargo.toml Added workspace dependencies and new oxish-proto member to workspace
Cargo.lock Updated dependency graph with new oxish-proto crate
oxish/Cargo.toml Updated to use workspace dependencies and added proto dependency
oxish/src/lib.rs Refactored to import from proto crate, updated Error enum to wrap ProtoError
oxish/src/terminal.rs Updated import to use proto crate for Mode and PtyReq types
oxish/src/connections.rs Updated imports and error types to use ProtoError from proto crate
oxish/src/key_exchange.rs Updated imports and error types to use proto crate types
oxish/src/buffers.rs Updated to import protocol types from proto crate and convert errors appropriately
oxish-proto/Cargo.toml New package configuration for the proto crate
oxish-proto/src/lib.rs Main module exporting protocol types, messages, and errors with appropriate visibility
oxish-proto/src/base.rs Base encoding/decoding types with updated error handling
oxish-proto/src/named.rs Named value types for protocol algorithms with updated visibility
oxish-proto/src/channels.rs Channel message types with updated error handling and visibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@djc djc merged commit 5f7083f into main Feb 19, 2026
6 checks passed
@djc djc deleted the proto branch February 19, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants