Conversation
There was a problem hiding this comment.
Pull request overview
This pull request extracts SSH protocol parsing and message handling code into a separate oxish-proto crate to improve modularity and code organization.
Changes:
- Created new
oxish-protocrate with protocol message types, encoding/decoding traits, and error types - Refactored
oxishcrate to use the newoxish-protodependency, updating imports and error handling - Consolidated error types by moving protocol-related errors into
ProtoErrorin the proto crate
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Added workspace dependencies and new oxish-proto member to workspace |
| Cargo.lock | Updated dependency graph with new oxish-proto crate |
| oxish/Cargo.toml | Updated to use workspace dependencies and added proto dependency |
| oxish/src/lib.rs | Refactored to import from proto crate, updated Error enum to wrap ProtoError |
| oxish/src/terminal.rs | Updated import to use proto crate for Mode and PtyReq types |
| oxish/src/connections.rs | Updated imports and error types to use ProtoError from proto crate |
| oxish/src/key_exchange.rs | Updated imports and error types to use proto crate types |
| oxish/src/buffers.rs | Updated to import protocol types from proto crate and convert errors appropriately |
| oxish-proto/Cargo.toml | New package configuration for the proto crate |
| oxish-proto/src/lib.rs | Main module exporting protocol types, messages, and errors with appropriate visibility |
| oxish-proto/src/base.rs | Base encoding/decoding types with updated error handling |
| oxish-proto/src/named.rs | Named value types for protocol algorithms with updated visibility |
| oxish-proto/src/channels.rs | Channel message types with updated error handling and visibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.