Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Add flags for create command#135

Merged
vdemeester merged 1 commit into
docker-archive-public:masterfrom
vdemeester:complete-create-flags
Jan 23, 2016
Merged

Add flags for create command#135
vdemeester merged 1 commit into
docker-archive-public:masterfrom
vdemeester:complete-create-flags

Conversation

@vdemeester
Copy link
Copy Markdown
Contributor

This adds the following flags (and support) for the create command :

  • force-recreate
  • no-recreate

The --no-build flag is shared with the up command and will be worked on in another PR 🐙.

  • Needs integration tests

🐸

Signed-off-by: Vincent Demeester vincent@sbr.pm

- force-recreate
- no-recreate

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
Comment thread cli/command/command.go
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to fix this context object. It doesn't make sense to have a single context for every command.

I think we should be using something like https://github.com/spf13/cobra to handle subcommands.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm working on that, but will be another PR..

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also isn't a switch better here?

vdemeester added a commit that referenced this pull request Jan 23, 2016
@vdemeester vdemeester merged commit 8774bac into docker-archive-public:master Jan 23, 2016
@vdemeester vdemeester deleted the complete-create-flags branch January 23, 2016 11:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants