Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

migrate to fsouza/go-dockerclient#78

Merged
vdemeester merged 2 commits into
docker-archive-public:masterfrom
imikushin:dc-comics
Oct 17, 2015
Merged

migrate to fsouza/go-dockerclient#78
vdemeester merged 2 commits into
docker-archive-public:masterfrom
imikushin:dc-comics

Conversation

@imikushin
Copy link
Copy Markdown
Contributor

@imikushin imikushin commented Oct 8, 2015

Implementing #71.

This is a work in progress because integration tests do not pass yet.

@imikushin
Copy link
Copy Markdown
Contributor Author

imikushin commented Oct 8, 2015

@vdemeester Jenkins complains about the library coding style. Looks like that dockerclient is below the our coding standards, as well as our own integration tests 😜

@ibuildthecloud
Copy link
Copy Markdown
Contributor

ibuildthecloud commented Oct 8, 2015

not sure why its checking stuff in Godeps, that's odd

@vdemeester
Copy link
Copy Markdown
Contributor

vdemeester commented Oct 8, 2015

hum.. there is some weird things going on with validate-golint.. 😓 Looking into it 😉

@imikushin
Copy link
Copy Markdown
Contributor Author

imikushin commented Oct 8, 2015

I've just rebased on top the latest master

@imikushin imikushin changed the title WIP: migrate to fsouza/go-dockerclient migrate to fsouza/go-dockerclient Oct 12, 2015
@imikushin
Copy link
Copy Markdown
Contributor Author

imikushin commented Oct 12, 2015

@ibuildthecloud @vdemeester I rebased again. Any human feedback on the code while robots are trying to build this? (Integration tests should pass: I've checked)

@ibuildthecloud
Copy link
Copy Markdown
Contributor

ibuildthecloud commented Oct 13, 2015

@imikushin I added comments on the commit imikushin@06d6abf

@imikushin imikushin force-pushed the dc-comics branch 2 times, most recently from 89f03d5 to 732c96a Compare October 14, 2015 12:20
@imikushin
Copy link
Copy Markdown
Contributor Author

imikushin commented Oct 15, 2015

Although I believe I've addressed all comments, I don't mind receiving more, especially, LGTM 😉

@imikushin
Update Godeps
0af2778 
Signed-off-by: Ivan Mikushin <i.mikushin@gmail.com>
@imikushin
Copy link
Copy Markdown
Contributor Author

imikushin commented Oct 15, 2015

Rebased and squashed, updated to using HostConfig.CPUSetCPUs instead of HostConfig.CPUSet (as per docker API 1.20). Updated create_test.go accordingly

@imikushin
Migrate to fsouza/go-dockerclient
efb950e 
Signed-off-by: Ivan Mikushin <i.mikushin@gmail.com>
@vdemeester
Copy link
Copy Markdown
Contributor

vdemeester commented Oct 16, 2015

Couple of nits, otherwise I think it's good to go.

@ibuildthecloud
Copy link
Copy Markdown
Contributor

ibuildthecloud commented Oct 17, 2015

LGTM

@vdemeester
Copy link
Copy Markdown
Contributor

vdemeester commented Oct 17, 2015

All right, LGTM for me too 🐸

vdemeester added a commit that referenced this pull request Oct 17, 2015
@vdemeester
Merge pull request #78 from imikushin/dc-comics
e2cddee 
migrate to fsouza/go-dockerclient
@vdemeester vdemeester merged commit e2cddee into docker-archive-public:master Oct 17, 2015
@thaJeztah
Copy link
Copy Markdown
Contributor

thaJeztah commented Oct 18, 2015

thank you @imikushin, great work! 🎉

@ibuildthecloud ibuildthecloud mentioned this pull request Oct 18, 2015
Closed
@brancz
Copy link
Copy Markdown
Contributor

brancz commented Oct 18, 2015

This is amazing stuff definitely going to be able to finish #45 nicely now!

@brancz brancz mentioned this pull request Oct 18, 2015
Closed
@imikushin
Copy link
Copy Markdown
Contributor Author

imikushin commented Oct 19, 2015

Really glad we did it 😺

@imikushin imikushin mentioned this pull request Oct 19, 2015
Closed
@imikushin imikushin deleted the dc-comics branch October 28, 2015 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

status/2-code-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@imikushin @ibuildthecloud @vdemeester @thaJeztah @brancz @GordonTheTurtle