This repository was archived by the owner on Jul 18, 2025. It is now read-only.
[proposal] Added amazonec2-use-default-network-interface option#3701
Open
bgokden wants to merge 1 commit intodocker-archive-public:masterfrom
Open
[proposal] Added amazonec2-use-default-network-interface option#3701bgokden wants to merge 1 commit intodocker-archive-public:masterfrom
bgokden wants to merge 1 commit intodocker-archive-public:masterfrom
Conversation
Contributor
Author
|
@nathanleclaire hi, can you look at it when you have time? |
| }} | ||
|
|
||
| var netSpecs []*ec2.InstanceNetworkInterfaceSpecification = nil | ||
| var securityGroupIds []*string = nil |
Contributor
There was a problem hiding this comment.
Why are these *string instead of string? Seems a potential nil deference panic
Contributor
Author
There was a problem hiding this comment.
I have used *string since func makePointerSlice(stackSlice []string) []*string returns []*string
…nterfaces parameter. - With use default network option, it is possible to use automatic network offered by the provider. Signed-off-by: Berk Gokden <berkgokden@gmail.com>
|
@nathanleclaire is there something you need before we can merge this? @bgokden left our company so he may not need this anymore, but it is still necessary for our ec2 compliant private cloud. I can help rebasing on master (or merge master into this branch?) to resolve conflicts. I did that already on my local machine, to validate this still works with latest version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added amazonec2-use-default-network-interface option to skip NetworkInterfaces parameter.
Signed-off-by: Berk Gokden berkgokden@gmail.com
This is required for our on-promise cluster to work. I am not sure if it helps anyone other than us. So it would be nice if someone who is using aws could review it.