This repository was archived by the owner on Jul 18, 2025. It is now read-only.
EC2: add support for launching instance store based images#4455
Open
Jawshua wants to merge 2 commits intodocker-archive-public:masterfrom
Open
EC2: add support for launching instance store based images#4455Jawshua wants to merge 2 commits intodocker-archive-public:masterfrom
Jawshua wants to merge 2 commits intodocker-archive-public:masterfrom
Conversation
|
Please sign your commits following these rules: $ git clone -b "amazonec2-instance-store-instances" git@github.com:Jawshua/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354128544
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Jawshua
force-pushed
the
amazonec2-instance-store-instances
branch
from
822a640 to
8197f25
Compare
added 2 commits
April 19, 2018 12:48
Also added the ap-northeast-3 region. Note: The cn-northwest-1 region is no longer listed on the Ubuntu AMI locator, therefore the images for this region have not been changed and there is no instance store AMI defined. Signed-off-by: Joshua Welsh <joshua.welsh@performancehorizon.com>
This commit adds the --amazonec2-instance-store-image flag, which does
two things:
- suppresses EBS block device configuration when provisioning
- uses instance store AMIs instead of EBS AMIs as the default
when the --amazonec2-ami flag is not set.
Signed-off-by: Joshua Welsh <joshua.welsh@performancehorizon.com>
Jawshua
force-pushed
the
amazonec2-instance-store-instances
branch
from
8197f25 to
550b8ee
Compare
|
This would be useful; any status updates? |
|
Just hopping in here too, this is something that would really help us too. If @Jawshua is ok with it, I could try and make a new PR based off their work? |
Author
By all means have at it. The only conflict appears to be updated AMI IDs, so it should be an easy branch to use as a basis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to launch instance store backed instances. Currently when launching an instance store AMI you are greeted with an error that looks something like this:
Resolves #1284