This repository was archived by the owner on Jul 18, 2025. It is now read-only.
Azure Create VM with named NSG#4486
Open
mitchellmaler wants to merge 3 commits intodocker-archive-public:masterfrom
mitchellmaler:feature/azure-nsg
Open
Azure Create VM with named NSG#4486mitchellmaler wants to merge 3 commits intodocker-archive-public:masterfrom mitchellmaler:feature/azure-nsg
mitchellmaler wants to merge 3 commits intodocker-archive-public:masterfrom
mitchellmaler:feature/azure-nsg
Conversation
|
Please sign your commits following these rules: $ git clone -b "feature/azure-nsg" git@github.com:mitchellmaler/machine.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354403000
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
…ting network security group. Added Network Security Group name for machine to saved state file. Will only remove NSG if there are no more NICs attached to it anymore which means the current VM being deleted was the last. Signed-off-by: Mitchell Maler <mitchell.maler@live.com>
Signed-off-by: Mitchell Maler <mitchell.maler@live.com>
mitchellmaler
changed the title
mitchellmaler
changed the title
Checking if NSG was not set which means it was created prior to new version. This will then just check for the default named one. Signed-off-by: Mitchell Maler <mitchell.maler@live.com>
|
Is there a plan to approve this PR, IT restricts NSG creation and this PR will solve that problem. |
michaelpearce-gain
pushed a commit
to michaelpearce-gain/machine
that referenced
this pull request
Nov 4, 2019
This is a patched version, with conflicts fixed of: docker-archive-public#4486
|
It's been a year and a half since this PR was opened, but it is needed... any status on accepting and merging? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added argument for the Azure driver to create or use an already existing network security group by name. Added Network Security Group name for machine to saved state file. Will only remove NSG if there are no more NICs attached to it anymore which means the current VM being deleted was the last.