Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

sync and close private and public key files#4579

Open
davidovich wants to merge 1 commit intodocker-archive-public:masterfrom
davidovich:ensure_ssh_key_files_are_closed
Open

sync and close private and public key files#4579
davidovich wants to merge 1 commit intodocker-archive-public:masterfrom
davidovich:ensure_ssh_key_files_are_closed

Conversation

@davidovich
Copy link
Copy Markdown

Description

Properly sync and close ssh public and private keys

Related issue(s)

Closes #4578

@GordonTheTurtle
Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "ensure_ssh_key_files_are_closed" git@github.com:davidovich/machine.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: David Genest <david.genest@gmail.com>
@davidovich davidovich force-pushed the ensure_ssh_key_files_are_closed branch from 2e57e1a to bf1f28a Compare September 25, 2018 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libmachine ssh keyPair.WriteToFile() does not close their File after writing

2 participants