[17.06] vndr libnetwork to bring in fix for overlay network ip reuse

[andrewhsu]

vndr libnetwork to specifically bring in this fix:

• [backport 17.06] Overlay fix for IP reuse moby/libnetwork#1912 [backport 17.06] Overlay fix for IP reuse

comparison of changes from the libnetwork repo: moby/libnetwork@2102668...9397626

[mavenugo]

LGTM

[mavenugo]

@andrewhsu

This change doesnt include :
docker/libnetwork#1901 Revert "Remove dynamic mac entry from fdb on endpoint deletion"

Pls remove it from the description.

[fcrisciani]

LGTM

[fcrisciani]

@mavenugo the diff does not show it because 17.06-CE did not vendor the libnetwork branch with the revert, so the final result is like that revert never happened

[mavenugo]

@fcrisciani thats correct. and hence, we should remove it from the description :)

[athurg]

I am completely confused.

Could you tell me whether docker-ce 17.06-1 include this fix or not?

I see the git commit from the released docker version is 874a737. Which is the children of commit 4770c7a and 99a2732 . These commits looks like included this PR.

And you guys's discussion here and the official release notes in https://docs.docker.com/release-notes/docker-ce/#17061-ce-2017-08-15 is shown this PR is not included.

[fcrisciani]

@athurg the patch is part of docker-ce 17.06.1.
The confusion comes from the fact that the issue overlay issue was fixed around 1 month ago, but during the testing of the recent RCs we found out that the specific patch was introducing a regression so we had to revert it for a week.
During this time docker-ce did not revendor libnetwork so that overlay issue never got introduced back to this repository. If you see the diff of libnetwork you can see the whole history where the patch is reverted: moby/libnetwork@2d5f452 and when it is brought back: moby/libnetwork@9587764 with the addition of the fix of the regression: moby/libnetwork@3113346

Hope this clarify the confusion, let me know if you have other questions

[athurg]

OK, I got it. Thanks for your explanation!