This repository was archived by the owner on Oct 13, 2023. It is now read-only.
WIP Explicitly add --detach to service CLI calls#255
Closed
seemethere wants to merge 1 commit into
Closed
Conversation
andrewhsu
changed the title
Contributor
|
Please sign your commits following these rules: $ git clone -b "test_detach" git@github.com:seemethere/docker-ce.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354185440
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
seemethere
force-pushed
the
test_detach
branch
from
2b8022a to
7fb64c5
Compare
This reverts commit efad9a6. Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
seemethere
force-pushed
the
test_detach
branch
from
7fb64c5 to
0e57541
Compare
Contributor
Author
|
Closed in favor of #260 |
docker-jenkins
pushed a commit
that referenced
this pull request
Nov 15, 2018
Merged with https://github.com/seemethere/unir Upstream-commit: dc8e682ed504309ced0f7f382c71b4e9fa4def07 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Jun 4, 2019
…river [19.03 backport] info: report cgroup driver as "none" when running rootless Upstream-commit: 287240a9653817e72bef3aea05068cc0402a85df Component: engine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##NOTE: this is a PR to just test
testsThe behavior of service (create/update/scale) was changed in a recent PR
to docker/cli. This commit serves to remedy test failures experienced
when attempting to use service calls.
Should not affect current behavior.
Signed-off-by: Eli Uriegas eli.uriegas@docker.com
(cherry picked from commit e5b3ebb)
Signed-off-by: Eli Uriegas eli.uriegas@docker.com