Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[17.10] ensure channel is allocated#261

Merged
andrewhsu merged 1 commit into
docker-archive:17.10from
seemethere:ensure_channel
Sep 30, 2017
Merged

[17.10] ensure channel is allocated#261
andrewhsu merged 1 commit into
docker-archive:17.10from
seemethere:ensure_channel

Conversation

@seemethere
Copy link
Copy Markdown
Contributor

@seemethere seemethere commented Sep 30, 2017 •
edited by andrewhsu
Loading

To remedy hanging tests as addressed in docker/cli#577

Signed-off-by: Stephen J Day stephen.day@docker.com
(cherry picked from commit e78772af4dca453ed97ff25b03adbaec2054859a)
Signed-off-by: Eli Uriegas eli.uriegas@docker.com

@stevvooe @seemethere
cli/command/container: ensure channel is allocated
7b99808 
Signed-off-by: Stephen J Day <stephen.day@docker.com>
(cherry picked from commit e78772af4dca453ed97ff25b03adbaec2054859a)
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere
Copy link
Copy Markdown
Contributor Author

seemethere commented Sep 30, 2017

Can confirm that this alleviates the panic that we were seeing earlier from the channel write.

Current failures are consistent and should be mostly alleviated by #260 with the exception of 2 tests:

  • DockerSuite.TestCpFromErrDstParentNotExists
  • DockerSuite.TestStatsNoStream
❯ ~/scripts/check_failures.sh https://jenkins.dockerproject.org/job/docker-ce-pr/272/consoleText
FOR: https://jenkins.dockerproject.org/job/docker-ce-pr/272/consoleText

Passed (thought would fail):
DockerSuite.TestRunAttachDetachFromInvalidFlag
DockerSuite.TestRunWithNanoCPUs
DockerSuite.TestUpdateWithNanoCPUs
DockerSwarmSuite.TestServiceLogs
DockerSwarmSuite.TestSwarmNetworkPluginV2
DockerSwarmSuite.TestSwarmServicePsMultipleServiceIDs

Failed (should fail)
DockerSuite.TestRmiContainerImageNotFound
DockerSuite.TestRmiImageIDForceWithRunningContainersAndMultipleTags

Failed (thought would pass):
DockerSuite.TestCpFromErrDstParentNotExists
DockerSuite.TestStatsNoStream
DockerTrustSuite.TestTrustedBuildTagFromReleasesRole
DockerTrustSuite.TestTrustedBuildTagIgnoresOtherDelegationRoles
DockerTrustSuite.TestTrustedPullIgnoresOtherDelegationRoles
DockerTrustSuite.TestTrustedPullReadsFromReleasesRole
DockerTrustSuite.TestTrustedPush
DockerTrustSuite.TestTrustedPushWithIncorrectPassphraseForNonRoot

andrewhsu
andrewhsu approved these changes Sep 30, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu added this to the 17.10.0 milestone Sep 30, 2017
@andrewhsu andrewhsu merged commit 8a6c4c9 into docker-archive:17.10 Sep 30, 2017
docker-jenkins pushed a commit that referenced this pull request Nov 28, 2018
@seemethere
Merge pull request #261 from thaJeztah/master_backport_remove_systemd
2d8b7f9 
[master] deb/systemd: remove
Upstream-commit: 84ded22
Component: packaging
wherka pushed a commit to wherka/docker-ce that referenced this pull request Dec 18, 2018
@seemethere
Merge pull request docker-archive#261 from thaJeztah/master_backport_…
6157d9e 
…remove_systemd

[master] deb/systemd: remove
Upstream-commit: 84ded22
Component: packaging
Upstream-commit: 2d8b7f9
Component: cli
docker-jenkins pushed a commit that referenced this pull request Jun 17, 2019
@andrewhsu
Merge pull request #261 from kolyshkin/19.03-aufs-lock
c751809 
[19.03 backport ENGCORE-831] aufs optimizations #39107
Upstream-commit: b9cd7b59b62f36fba67cbee657ded039b52a0d55
Component: engine
akrasnov-drv pushed a commit to drivenets/docker-ce that referenced this pull request Apr 23, 2023
@seemethere
Merge pull request docker-archive#261 from thaJeztah/master_backport_…
84ded22 
…remove_systemd

[master] deb/systemd: remove
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@andrewhsu andrewhsu andrewhsu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

17.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seemethere @andrewhsu @stevvooe