This repository was archived by the owner on Oct 13, 2023. It is now read-only.
[18.03] backport docs and completion fixes#519
Merged
andrewhsu merged 9 commits intoApr 18, 2018
Conversation
`--rm` moved to the daemon, so is now also supported when combined with `-d`. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit e9ce688d6e6d990794b51fac5ed2fed619c89f4f) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This clarifies that the behaviour of `unless-stopped` will restart the container on daemon start. This was implied before, but now the restart-on-daemon-start behaviour is mentioned directly. Signed-off-by: David Beitey <david@davidjb.com> (cherry picked from commit 8ca237054f13c585ce5880c2c193d106ac22c9cd) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Explicitly stated that you must add --build-arg for each build argument. Added multiple arguments to example of `--build-arg` usage. Fix for docker/docs#6248 Signed-off-by: Preston Cowley <cowlinator@gmail.com> (cherry picked from commit ad44e2d45e35d09890473e20f6b2ad16de98d72a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Update the docs so that users don't use `echo` when creating secrets from STDIN. `echo` adds a trailing new line, so users will probably be confused when their passwords don't work. Signed-off-by: Joao Fernandes <joao.fernandes@docker.com> (cherry picked from commit 5238f3e93e6141b3615e7c8b38adae5ea2175385) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 2f7bf40e733e337dadc998ae99d93fe5da5e4a16) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com> (cherry picked from commit 5fd9eab3d0cec4d1fb3d03cd9eb4c250cf2bd23a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This use case is currently _working correctly_, which is nice, but there is no documentation to be found about it. This PR fixes that. Signed-off-by: Per Lundberg <perlun@gmail.com> (cherry picked from commit 82c23208eeba822473d444221399a7102479a702) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Remove the double "docker docker" from example Signed-off-by: Henry Ne <henrynmail-github@yahoo.de> (cherry picked from commit 79c489d812524ae5a0ff26c44fa4bb2e309810bb) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Harald Albers <github@albersweb.de> (cherry picked from commit 43024e2d57d7bdd63c358ac65bc3c6d1e6a4d702) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Member
Author
|
ping @anusha-ragunathan @vdemeester @andrewhsu PTAL |
Member
Author
|
No need to restart CI, as these aren't tested, but listing failures to keep track of flakiness: PowerPC https://jenkins.dockerproject.org/job/docker-ce-pr-ppc64le/558/execution/node/467/log/ s390x https://jenkins.dockerproject.org/job/docker-ce-pr-s390x/567/execution/node/366/log/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs and completion cherry-picks for 18.03 of:
secret|config create --template-driverdocker/cli#1004 Add bash completion forsecret|config create --template-driverno conflicts