Skip to content
This repository was archived by the owner on Oct 13, 2023. It is now read-only.

[19.03 backport] builder-next: userns remap support#290

Closed
thaJeztah wants to merge 3 commits into
docker-archive:19.03from
thaJeztah:19.03_backport_buildkit_userns_remap
Closed

[19.03 backport] builder-next: userns remap support#290
thaJeztah wants to merge 3 commits into
docker-archive:19.03from
thaJeztah:19.03_backport_buildkit_userns_remap

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Jun 27, 2019 •
edited
Loading

backport for 19.03 of

Allow buildkit builds with userns-remap flag.

fixes moby/buildkit#943 for 19.03
fixes moby#39442 for 19.03

@tonistiigi @thaJeztah
builder-next: userns remap support
7701a75 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit 07b3aac)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@tonistiigi @thaJeztah
vendor: update buildkit to c242750
37e3662 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit 5c48489)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 19.03.0 milestone Jun 27, 2019
@thaJeztah thaJeztah requested a review from tonistiigi as a code owner June 27, 2019 08:34
@thaJeztah thaJeztah mentioned this pull request Jun 27, 2019
Closed
@AkihiroSuda
Copy link
Copy Markdown

AkihiroSuda commented Jul 1, 2019

This one is causing regression moby#39442

@thaJeztah thaJeztah changed the title [19.03 backport] builder-next: userns remap support [WIP][19.03 backport] builder-next: userns remap support Jul 1, 2019
@tonistiigi @thaJeztah
builder-next: reset identitymapping if empty
222d010 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
(cherry picked from commit 0bdcc60)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah mentioned this pull request Jul 2, 2019
Merged
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Jul 2, 2019

cherry-picked moby#39444 into this PR

@thaJeztah thaJeztah changed the title [WIP][19.03 backport] builder-next: userns remap support [19.03 backport] builder-next: userns remap support Jul 2, 2019
@thaJeztah thaJeztah mentioned this pull request Jul 18, 2019
Closed
@thaJeztah thaJeztah modified the milestones: 19.03.0, 19.03.1, 19.03.2 Jul 23, 2019
@thaJeztah thaJeztah mentioned this pull request Aug 8, 2019
Merged
@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Aug 9, 2019

replaced by #316

@thaJeztah thaJeztah closed this Aug 9, 2019
@thaJeztah thaJeztah deleted the 19.03_backport_buildkit_userns_remap branch August 9, 2019 01:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

19.03.2

Development

Successfully merging this pull request may close these issues.

3 participants

@thaJeztah @AkihiroSuda @tonistiigi