This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Fix some suspicious things in vendor#635
Merged
Merged
Conversation
It tests only changed files from commit. We can't expect vet fixes from all projects from vendor directory. Signed-off-by: Alexander Morozov <lk4d4@docker.com>
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
Contributor
There was a problem hiding this comment.
Are we making a change or undoing something that was done earlier?
Contributor
Author
There was a problem hiding this comment.
Undoing, I think @avagin did this for passing CI and forgot about it.
Contributor
|
LGTM |
1 similar comment
Contributor
|
LGTM |
dqminh
added a commit
that referenced
this pull request
Jun 17, 2015
Fix some suspicious things in vendor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed hash for gocapability and re-run vendor script. Also I change vet validation to use docker version, which run vet only on changed files to skip
golang/protobufwarning.We discovered those issues in #633