Skip to content

Add explicit support to GitHub Actions scripts for ".test/config.sh" … #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianon merged 1 commit into from
Jun 24, 2022
Merged

Add explicit support to GitHub Actions scripts for ".test/config.sh" … #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion scripts/github-actions/generate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,14 @@ for tag in $tags; do
| join(" ")
),
history: ("docker history " + (.tags[0] | @sh)),
test: ("~/oi/test/run.sh " + (.tags[0] | @sh)),
test: (
[
"set -- " + (.tags[0] | @sh),
# https://github.com/docker-library/bashbrew/issues/46#issuecomment-1152567694 (allow local test config / tests)
"if [ -s ./.test/config.sh ]; then set -- --config ~/oi/test/config.sh --config ./.test/config.sh \"$@\"; fi",
"~/oi/test/run.sh \"$@\""

@williamdes williamdes Jun 22, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you echo to gha output that you used the override config
So people do not have to debug the script

@tianon tianon Jun 22, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at https://github.com/tianon/dockerfiles/runs/6889534295?check_suite_focus=true#step:7:10, we run all these with set -x so we kind of get that "for free" 😅

@williamdes williamdes Jun 23, 2022

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, explicit github ci output would be nice but okay for me 😆

] | join("\n")
),
},
}
'
Expand Down