Add 29.5.0#575
Merged
Merged
Conversation
Member
Author
|
Line 221 in 132c91a
|
- drop vpnkit for 29.5+ moby/moby#52319
Contributor
|
@AkihiroSuda could you have a quick peek if the changes for rootless are correct? |
AkihiroSuda
reviewed
May 15, 2026
| # [rootlesskit:child ] error: executing [[ip tuntap add name tap0 mode tap] [ip link set tap0 address 02:50:00:00:00:01]]: exit status 1 | ||
| # slirp4netns can be selected as rootlesskit's net driver using "-e DOCKERD_ROOTLESS_ROOTLESSKIT_NET=slirp4netns" | ||
| # slirp4netns is recommended as rootlesskit's net driver | ||
| # https://github.com/rootless-containers/rootlesskit/blob/be156df0429551f5c23dc61dd07201b33076ff1d/docs/network.md#--netslirp4netns-recommended |
Contributor
There was a problem hiding this comment.
(slirp4netns is no longer necessarily required, as gvisor-tap-vsock is now embedded in rootlesskit)
Contributor
There was a problem hiding this comment.
In that case, should we simplify, and remove these bits ?
There was a problem hiding this comment.
Yeah I think we should get rid of the slirp4netns is recommended as rootlesskit's net driver, as its no longer recommended over the default?
Contributor
There was a problem hiding this comment.
Yes, I suggest removing slirp4netns.
3 tasks
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
May 15, 2026
Changes: - docker-library/docker@55b0b1c: Add 29.5.0 (docker-library/docker#575) - docker-library/docker@132c91a: Update 29 to buildx 0.34.0
yosifkit
added a commit
to docker-library/official-images
that referenced
this pull request
May 15, 2026
Changes: - docker-library/docker@55b0b1c: Add 29.5.0 (docker-library/docker#575) - docker-library/docker@132c91a: Update 29 to buildx 0.34.0 Co-authored-by: Docker Library Bot <doi+docker-library-bot@docker.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vpnkitis no longer included in thedocker-rootless-extras-*.tgzand is no longer necessary for RootlessKit 3.0.0: moby/moby#52319Since it is no longer included, the automated update job cannot successfully build the
29.5.0release: