Add sharp module building#394
Closed
yosifkit wants to merge 1 commit into
Closed
Conversation
Member
|
Agreed, without something automated checking/verifying that whole chain of deps, this is not ideal. 😞 |
Member
Author
|
Closing since we dropped the architectures that don't have prebuilt sharp/vips modules in #456. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alpine 3.17 lib-vips is new enough for sharp
https://github.com/TryGhost/Ghost/blob/v5.65.1/yarn.lock#L28340-L28341
https://github.com/lovell/sharp/blob/v0.30.7/package.json#L157
https://pkgs.alpinelinux.org/packages?name=vips-dev&branch=v3.17
⬆️ this is a lot of manual checking to see which version of
sharpthat Ghost requires, and then which version oflibvipsthatsharprequires, and then checking if that is available in the Alpine release we are on. I'd rather have some automation (in the Dockerfile?) to check these assumptions before just addingsharpback to thebuild-from-sourcedeps.Closes #293